fix: handle token hook auth config #3677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-jonas
previously approved these changes
Dec 15, 2023
hperl
force-pushed
the
hperl/fix-token-hook-config
branch
from
89806f6
to
88d4c1d
Compare
jonas-jonas
force-pushed
the
hperl/fix-token-hook-config
branch
from
d3526ff
to
3ebd911
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3677 +/- ##
=======================================
Coverage 76.01% 76.01%
=======================================
Files 134 134
Lines 10077 10036 -41
=======================================
- Hits 7660 7629 -31
+ Misses 1905 1900 -5
+ Partials 512 507 -5 ☔ View full report in Codecov by Sentry. |
aeneasr
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that fetches the auth config for the token hook incorrectly assumed that koanf returns JSON, when instead it is a nested
map[string]any. This code fixes that.Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments